[Ruby]- rvm - fallback code fix - #931
Merged
Samruddhi Khandale (samruddhikhandale) merged 8 commits intoApr 16, 2024
Merged
Conversation
Samruddhi Khandale (samruddhikhandale)
marked this pull request as ready for review
April 2, 2024 21:36
Samruddhi Khandale (samruddhikhandale)
requested a review
from a team
as a code owner
April 2, 2024 21:36
Samruddhi Khandale (samruddhikhandale)
requested changes
Apr 2, 2024
Samruddhi Khandale (samruddhikhandale)
approved these changes
Apr 16, 2024
Samruddhi Khandale (samruddhikhandale)
left a comment
Samruddhi Khandale (samruddhikhandale)
left a comment
Member
There was a problem hiding this comment.
Looks good!
hhjmmmmmmmm
approved these changes
May 3, 2024
hhjmmmmmmmm
approved these changes
May 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature name:
Description:
This PR adds the following functionality:
find_prev_version_from_git_tags()to install if rate limit for the user accessing GitHub api is reached and installation begins to fail using this fallback method as wellChangelog:
install.shChecklist: